excel - Macro to pull data from closed workbook to another workbook -


i writing macro following:

every time open workbook, pull data closed workbook on computer , copy data sheet titled "availability" starting in cell a1.

currently, happens "true" put cell a1 on availability sheet.

please help.

sub openworkbooktopulldata()      dim sht worksheet     dim lastrow long     lastrow = activesheet.usedrange.rows.count     set sht = thisworkbook.worksheets(sheet1.name)     dim path string     path = "c:\users\" & environ$("username") & _     "\desktop\rc switch project\daily automation _     availability report.xlsx"      dim currentwb workbook     set currentwb = thisworkbook      dim openwb workbook     set openwb = workbooks.open(path)      dim openws worksheet     set openws = openwb.sheets("automation data")      currentwb.sheets("availability").range("a1") _     = openws.range("a5:k" & lastrow).select     openwb.close (false)  end sub

as @greg mentioned, .select not needed. once removed though, have new problem 2 ranges not same size. range("a1") 1 cell while other range @ least 11. current vba overwrite values in range called for, a1 here.

to around there 2 approaches work well.

resize

resize left hand side same size right hand side.

sub openworkbooktopulldata()      dim sht worksheet     dim lastrow long     lastrow = activesheet.usedrange.rows.count     set sht = thisworkbook.worksheets(sheet1.name)     dim path string     path = "c:\users\" & environ$("username") & _     "\desktop\rc switch project\daily automation availability report.xlsx"      dim currentwb workbook     set currentwb = thisworkbook      dim openwb workbook     set openwb = workbooks.open(path)      dim openws worksheet     set openws = openwb.sheets("automation data")      dim rng_data range     set rng_data = openws.range("a5:k" & lastrow)      currentwb.sheets("availability").range("a1").resize( _         rng_data.rows.count, rng_data.columns.count).value = rng_data.value      openwb.close (false)  end sub

copy/pastespecial

actually copy , pastespecial.

sub openworkbooktopulldata()      dim sht worksheet     dim lastrow long     lastrow = activesheet.usedrange.rows.count     set sht = thisworkbook.worksheets(sheet1.name)     dim path string     path = "c:\users\" & environ$("username") & _     "\desktop\rc switch project\daily automation availability report.xlsx"      dim currentwb workbook     set currentwb = thisworkbook      dim openwb workbook     set openwb = workbooks.open(path)      dim openws worksheet     set openws = openwb.sheets("automation data")      dim rng_data range     set rng_data = openws.range("a5:k" & lastrow)      rng_data.copy     currentwb.sheets("availability").range("a1").pastespecial xlpastevalues      openwb.close (false)  end sub

since looks going values anyways, use copy/pastespecial route clarity in code.


-

Comments

Post a Comment

Popular posts from this blog

css - SVG using textPath a symbol not rendering in Firefox -

using textpath within symbol doesn't render in firefox. renders fine in latest chrome , ie, when try reference symbol, svg text doesn't render in firefox (37.0.1) - first box appears empty. code below (no external dependencies), there should 2 boxes word test flowing vertically in centre of each. edit: thought issue somehow involved flexbox layout, until paul pointed out issue exists without flexbox layout. the html is: <div> <svg id="not_working" viewbox="0 0 250 1200" preserveaspectratio="xmidymid meet"> <symbol id="test_symbol1" preserveaspectratio="xmidymid meet" viewbox="0 0 250 1200"> <path id="test_symbol_path" d="m 100 1200 l 100 0" /> <text font-size="100" fill="red"> <textpath text-anchor="middle" startoffset="50%" xlink:href="#test_symbol_path...
Read more

Java 8 + Maven Javadoc plugin: Error fetching URL -

i attempting generate javadoc links javadoc dependencies. have tried various means generate javadoc not produce qualified class names references classes dependencies. wanted links java doc simplified class names. however, java api classnames, no links , have qualified class names. working java 8. have following configuration: <plugin> <groupid>org.apache.maven.plugins</groupid> <artifactid>maven-javadoc-plugin</artifactid> <version>2.10.2</version> <configuration> <reportoutputdirectory>${project.basedir}/target</reportoutputdirectory> <destdir>javadoc</destdir> <windowtitle>epiphany</windowtitle> <doctitle>epiphany</doctitle> <show>private</show> <detectlinks>false</detectlinks> <detectoffline...
Read more

datatable - Matlab struct computations -

i download data yahoo! finance with: data = getyahoodailydata({'msft', 'axp'},'01/01/2000', '01/01/2015', 'dd/mm/yyyy'); and data stored 1x1 struct. want create tx2 matrix of daily adjusted closing prices msft , axp, column 7 in each table in struct. how can that? or better : there way make computations directly on information/prices in struct? you can access data in struct name. vecmsftadj = data.msft.adjclose; vecaxpadj = data.axp.adjclose; % if want n x 2 matrix madjclose = [vecmsftadj, vecaxpadj]; % personnaly prefer working table tadjclose = table; tadjclose.msftadj = vecmsftadj; tadjclose.axpadj = vecaxpadj;
Read more